Issue 5754060: code review 5754060: net: disable another external network test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5754060: code review 5754060: net: disable another external network test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

net: disable another external network test I don't know enough about multicast. Should this be disabled on all systems, not just Windows?

Patch Set 1 #

Patch Set 2 : diff -r fdb871a77eef https://code.google.com/p/go/ #

Patch Set 3 : diff -r fdb871a77eef https://code.google.com/p/go/ #

Patch Set 4 : diff -r 28ed5c1852a8 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/pkg/net/multicast_test.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-07 04:46:05 UTC) #1

rsc

13 years, 2 months ago (2012-03-07 05:02:10 UTC) #2

*** Submitted as 2b1a6605a310 ***

net: disable another external network test

I don't know enough about multicast.
Should this be disabled on all systems, not just Windows?

R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5754060

Expand All Messages | Collapse All Messages