Issue 5753065: code review 5753065: deps: allow crypto/x509 to use syscall

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5753065: code review 5753065: deps: allow crypto/x509 to use syscall (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mkrautz

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

deps: allow crypto/x509 to use syscall Allows the Windows part of CL 5700087 to land. I had build tested CL 5753060 (which allows crypto/x509 to use cgo and io/ioutil), and didn't spot any errors on Windows. Turns out I was wrong.

Patch Set 1 #

Patch Set 2 : diff -r 3d22f43c0b98 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3d22f43c0b98 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/go/build/deps_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mkrautz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-06 23:59:31 UTC) #1

rsc

13 years, 2 months ago (2012-03-07 18:51:09 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=82391e949932 ***

deps: allow crypto/x509 to use syscall

Allows the Windows part of CL 5700087 to land.

I had build tested CL 5753060 (which allows
crypto/x509 to use cgo and io/ioutil), and
didn't spot any errors on Windows.

Turns out I was wrong.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5753065

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages