Issue 5753060: code review 5753060: deps: allow crypto/x509 cgo and io/ioutil.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5753060: code review 5753060: deps: allow crypto/x509 cgo and io/ioutil. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by agl1

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc, mkrautz

Visibility:
Public.

Description

deps: allow crypto/x509 cgo and io/ioutil. In order to land 5700087 (which moves the knowledge of how to get the root certificates for the system from crypto/tls to crypto/x509), we need to relax the restrictions on crypto/x509. Afterwards, we can probably tighten them up in crypto/tls.

Patch Set 1 #

Patch Set 2 : diff -r 677b60c6d1e7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 677b60c6d1e7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a9c5c88d2904 https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/go/build/deps_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-03-06 18:09:19 UTC) #1

agl1

13 years, 2 months ago (2012-03-06 22:18:16 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=3d22f43c0b98 ***

deps: allow crypto/x509 cgo and io/ioutil.

In order to land 5700087 (which moves the knowledge of how to get the
root certificates for the system from crypto/tls to crypto/x509), we
need to relax the restrictions on crypto/x509. Afterwards, we can
probably tighten them up in crypto/tls.

R=golang-dev, rsc, krautz
CC=golang-dev
http://codereview.appspot.com/5753060

Expand All Messages | Collapse All Messages