Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(962)

Issue 5753054: code review 5753054: test/run: use all available cores on ARM system (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by minux1
Modified:
13 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

test/run: use all available cores on ARM system

Patch Set 1 #

Patch Set 2 : diff -r c1f5756f94b0 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r c1f5756f94b0 https://code.google.com/p/go/ #

Patch Set 4 : diff -r c1f5756f94b0 https://code.google.com/p/go/ #

Patch Set 5 : diff -r c1f5756f94b0 https://code.google.com/p/go/ #

Patch Set 6 : diff -r a1366c7906fb https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M test/run.go View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6
rsc1
http://codereview.appspot.com/5753054/diff/2001/test/run.go File test/run.go (right): http://codereview.appspot.com/5753054/diff/2001/test/run.go#newcode33 test/run.go:33: numParallel = flag.Int("n", get_default_parallelism(), "number of parallel tests to ...
13 years, 2 months ago (2012-03-06 14:32:46 UTC) #1
minux1
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-03-06 14:37:51 UTC) #2
rsc
Let's just go back to a default of runtime.NumCPU() and then we don't need the ...
13 years, 2 months ago (2012-03-06 14:41:32 UTC) #3
minux1
PTAL. On Tue, Mar 6, 2012 at 10:41 PM, Russ Cox <rsc@golang.org> wrote: > Let's ...
13 years, 2 months ago (2012-03-06 14:48:09 UTC) #4
rsc
LGTM
13 years, 2 months ago (2012-03-07 02:34:56 UTC) #5
minux1
13 years, 2 months ago (2012-03-07 04:43:33 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=e161795e4095 ***

test/run: use all available cores on ARM system

R=rsc
CC=golang-dev
http://codereview.appspot.com/5753054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b