code review 5752058: time: during short test, do not bother tickers take lon...

time: during short test, do not bother tickers take longer than expected

[minux1, 2012-03-06 17:02:21]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-03-06 17:07:04]

LGTM
 On Mar 6, 2012 9:02 AM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> time: during short test, do not bother tickers take longer than expected
>
> Please review this at
http://codereview.appspot.com/**5752058/<http://codereview.appspot.com/5752058/>
>
> Affected files:
>  M src/pkg/time/tick_test.go
>
>
> Index: src/pkg/time/tick_test.go
> ==============================**==============================**=======
> --- a/src/pkg/time/tick_test.go
> +++ b/src/pkg/time/tick_test.go
> @@ -22,7 +22,7 @@
>        dt := t1.Sub(t0)
>        target := Delta * Count
>        slop := target * 2 / 10
> -       if dt < target-slop || dt > target+slop {
> +       if dt < target-slop || (!testing.Short() && dt > target+slop) {
>                t.Fatalf("%d %s ticks took %s, expected [%s,%s]", Count,
> Delta, dt, target-slop, target+slop)
>        }
>        // Now test that the ticker stopped
>
>
>

[minux1, 2012-03-06 17:11:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=cfdcc1f276a2 ***

time: during short test, do not bother tickers take longer than expected

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5752058