Issue 5752054: code review 5752054: cmd/go: honour buildflags in go run

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5752054: code review 5752054: cmd/go: honour buildflags in go run (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mpimenov

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: honour buildflags in go run Either documentation or implementation of go run's flags is wrong currently. This change assumes the documentation to be right.

Patch Set 1 #

Patch Set 2 : diff -r c1f5756f94b0 https://code.google.com/p/go #

Patch Set 3 : diff -r c1f5756f94b0 https://code.google.com/p/go #

Patch Set 4 : diff -r c1f5756f94b0 https://code.google.com/p/go #

Patch Set 5 : diff -r c1f5756f94b0 https://code.google.com/p/go #

Patch Set 6 : diff -r c1f5756f94b0 https://code.google.com/p/go #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/cmd/go/run.go	View	1 2 3 4	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mpimenov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

13 years, 2 months ago (2012-03-06 10:18:56 UTC) #1

rsc

I think I just forgot to edit run.go. Can you make it call addBuildFlags instead ...

13 years, 2 months ago (2012-03-06 14:23:38 UTC) #2

mpimenov

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 2 months ago (2012-03-06 14:30:40 UTC) #3

rsc

*** Submitted as f6523e003ea9 *** cmd/go: honour buildflags in go run Either documentation or implementation ...

13 years, 2 months ago (2012-03-06 14:33:41 UTC) #4

LGTM

Thanks.

Expand All Messages | Collapse All Messages