Issue 5739043: code review 5739043: doc/effective_go: minor fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5739043: code review 5739043: doc/effective_go: minor fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by minux1

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, Kyle E. Lemons, r

Visibility:
Public.

Description

doc/effective_go: minor fix We have 'gofmt' and 'go fmt', but not 'go tool fmt'.

Patch Set 1 #

Patch Set 2 : diff -r a2275531cfe0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a2275531cfe0 https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	doc/effective_go.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	doc/effective_go.tmpl	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-04 13:37:39 UTC) #1

Kyle E. Lemons

On 2012/03/04 13:37:39, minux wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

13 years, 2 months ago (2012-03-04 22:33:47 UTC) #2

minux1

On 2012/03/04 22:33:47, Kyle E. Lemons wrote: > I think the proper fix might be ...

13 years, 2 months ago (2012-03-05 00:07:52 UTC) #3

13 years, 2 months ago (2012-03-05 00:13:04 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=61d59e66b8ff ***

doc/effective_go: minor fix
        We have 'gofmt' and 'go fmt', but not 'go tool fmt'.

R=golang-dev, kyle, r
CC=golang-dev
http://codereview.appspot.com/5739043

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages