Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 5730059: code review 5730059: cmd/godoc: remove extra / in paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by ugorji
Modified:
13 years ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/godoc: remove extra / in paths If I click on links which should send you to source code (e.g. type, function, etc), the link is to //src/... (instead of /src/...). This causes a DNS resolution failure on the browser. Quick fix is to remove the leading / from package.html (since godoc.go src links automatically add a leading / as necessary). Fixes issue 3193.

Patch Set 1 #

Patch Set 2 : diff -r ea5cd2b9ca6c https://code.google.com/p/go/ #

Patch Set 3 : diff -r ea5cd2b9ca6c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M lib/godoc/package.html View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8
ugorji
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 2 months ago (2012-03-05 16:05:15 UTC) #1
rsc
LGTM Thanks
13 years, 2 months ago (2012-03-05 18:28:33 UTC) #2
rsc
I do not see your name in our CONTRIBUTORS list, and I don't see that ...
13 years, 2 months ago (2012-03-05 18:30:54 UTC) #3
ugorji
Thanks Russ. I'd like to be credited and so that I can make future changes. ...
13 years, 2 months ago (2012-03-05 19:01:39 UTC) #4
rsc
I'll roll this into my own CL. I'd like to fix this soon.
13 years, 2 months ago (2012-03-05 20:23:09 UTC) #5
ugorji
Hi russ hi responded on codereview. I filled out a cla. On Mar 5, 2012 ...
13 years, 2 months ago (2012-03-05 20:26:27 UTC) #6
rsc
Codereview isn't delivering email it appears. Will do.
13 years, 2 months ago (2012-03-05 20:31:20 UTC) #7
rsc
13 years, 2 months ago (2012-03-05 20:36:35 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=faadc270f4d8 ***

cmd/godoc: remove extra / in paths

If I click on links which should send you to source code (e.g. type, function,
etc),
the link is to //src/... (instead of /src/...).
This causes a DNS resolution failure on the browser.

Quick fix is to remove the leading / from package.html
(since godoc.go src links automatically add a leading / as necessary).

Fixes issue 3193.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5730059

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b