code review 5728064: cmd/gc: show duplicate key in error

cmd/gc: show duplicate key in error

[rsc, 2012-03-05 18:47:34]

Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-03-05 18:47:39]

*** Submitted as http://code.google.com/p/go/source/detail?r=613e2fda5721 ***

cmd/gc: show duplicate key in error

R=ken2
CC=golang-dev
http://codereview.appspot.com/5728064

[gri, 2012-03-05 18:47:59]

LGTM

On Mon, Mar 5, 2012 at 10:47 AM,  <rsc@golang.org> wrote:
> Reviewers: ken2,
>
> Message:
> Hello ken2 (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/gc: show duplicate key in error
>
> Please review this at http://codereview.appspot.com/5728064/
>
> Affected files:
>  M src/cmd/gc/typecheck.c
>
>
> Index: src/cmd/gc/typecheck.c
> ===================================================================
> --- a/src/cmd/gc/typecheck.c
> +++ b/src/cmd/gc/typecheck.c
> @@ -1964,7 +1964,7 @@
>                b = cmp.val.u.bval;
>                if(b) {
>                        // too lazy to print the literal
> -                       yyerror("duplicate key in map literal");
> +                       yyerror("duplicate key %N in map literal", n);
>                        return;
>                }
>        }
>
>

[ken3, 2012-03-05 20:08:22]

lgtm