Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2794)

Issue 5728052: Enhancement of pose bones rotation/scaling parenting

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by b.mont29
Modified:
11 years, 11 months ago
Reviewers:
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch replaces the Hinge/No Scale options of bones by the ability to choose any bone upper in the chain as rotation/scale reference. So choosing the immediate parent is usual behavior, choosing none is old Hinge and/or No Scale, and choosing another bone… is new option! On a code level, it adds two new rot_parent and scale_parent bones pointers to each bone, and adapt the pose bone evaluation code, as well as many editing code (to check/avoid invalid situations when adding/reparenting/removing/etc. bones in EditMode). Coded from an idea of Bassam Kurdali (which did first tests of this patch on a user POV). Patch not yet definitive, have a few additional suggestions to implement.

Patch Set 1 #

Patch Set 2 : Patch updated… #

Patch Set 3 : Updated patch... #

Patch Set 4 : Updated the patch against r45134, and fixed some problems #

Patch Set 5 : updated against svn45317… #

Patch Set 6 : simple update against current trunk… #

Patch Set 7 : another update against current trunk #

Patch Set 8 : another update against current trunk #

Patch Set 9 : another update against current trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -107 lines) Patch
release/scripts/startup/bl_ui/properties_data_bone.py View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
release/scripts/startup/bl_ui/space_view3d.py View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
source/blender/blenkernel/BKE_blender.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
source/blender/blenkernel/intern/armature.c View 1 2 3 4 5 6 7 8 2 chunks +82 lines, -17 lines 0 comments Download
source/blender/blenloader/intern/readfile.c View 1 2 3 4 5 6 7 8 3 chunks +30 lines, -1 line 0 comments Download
source/blender/blenloader/intern/writefile.c View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -1 line 0 comments Download
source/blender/editors/armature/editarmature.c View 1 2 3 4 5 6 7 8 32 chunks +217 lines, -63 lines 0 comments Download
source/blender/editors/armature/editarmature_generate.c View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/armature/editarmature_retarget.c View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
source/blender/editors/armature/editarmature_sketch.c View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
source/blender/editors/include/ED_armature.h View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
source/blender/editors/transform/transform_conversions.c View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
source/blender/makesdna/DNA_armature_types.h View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -3 lines 0 comments Download
source/blender/makesrna/intern/rna_armature.c View 1 2 3 4 5 6 7 8 8 chunks +159 lines, -12 lines 0 comments Download

Messages

Total messages: 9
mont29
12 years, 1 month ago (2012-03-03 09:05:01 UTC) #1
mont29
Patch updated…
12 years, 1 month ago (2012-03-12 18:54:10 UTC) #2
mont29
Updated patch...
12 years, 1 month ago (2012-03-15 20:38:28 UTC) #3
mont29
Updated the patch against r45134, and fixed some problems
12 years ago (2012-03-25 12:43:56 UTC) #4
mont29
updated against svn45317…
12 years ago (2012-04-01 09:28:31 UTC) #5
mont29
simple update against current trunk…
12 years ago (2012-04-22 16:10:09 UTC) #6
mont29
another update against current trunk
11 years, 11 months ago (2012-05-05 13:44:36 UTC) #7
mont29
another update against current trunk
11 years, 11 months ago (2012-05-20 12:07:58 UTC) #8
mont29
11 years, 11 months ago (2012-05-27 12:01:14 UTC) #9
another update against current trunk
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b