code review 5727059: misc/dist: add windows packaging support

misc/dist: add windows packaging support

[adg, 2012-03-05 09:16:49]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bsiegert, 2012-03-05 13:57:17]

http://codereview.appspot.com/5727059/diff/5001/misc/dist/bindist.go
File misc/dist/bindist.go (right):

http://codereview.appspot.com/5727059/diff/5001/misc/dist/bindist.go#newcode171
misc/dist/bindist.go:171: win := filepath.Join(b.root, "misc/dist/windows")
Should this be:
win := filepath.Join(b.root, "misc", "dist", "windows")

http://codereview.appspot.com/5727059/diff/5001/misc/dist/windows/README.txt
File misc/dist/windows/README.txt (right):

http://codereview.appspot.com/5727059/diff/5001/misc/dist/windows/README.txt#...
misc/dist/windows/README.txt:17: - Documentation server shortcut checkbox option
What?

[Joe Poirier, 2012-03-05 18:26:52]

http://codereview.appspot.com/5727059/diff/5001/misc/dist/windows/README.txt
File misc/dist/windows/README.txt (right):

http://codereview.appspot.com/5727059/diff/5001/misc/dist/windows/README.txt#...
misc/dist/windows/README.txt:17: - Documentation server shortcut checkbox option
On 2012/03/05 13:57:17, bsiegert wrote:
> What?
The installer puts a shortcut icon on the user's dektop that, when clicked,
starts the Go doc server and opens a web browser pointing to localhost:6060
(local golang webpage).

Some people don't like shortcuts added to their desktop, so having an opt out
checkbox option as part of the installer would be nice.

-joe

[Joe Poirier, 2012-03-05 21:00:33]

LGTM

[adg, 2012-03-05 21:02:05]

On Mar 6, 2012 12:57 AM, <bsiegert@gmail.com> wrote:
>
>
> http://codereview.appspot.com/5727059/diff/5001/misc/dist/bindist.go
> File misc/dist/bindist.go (right):
>
>
http://codereview.appspot.com/5727059/diff/5001/misc/dist/bindist.go#newcode171
> misc/dist/bindist.go:171: win := filepath.Join(b.root,
> "misc/dist/windows")
> Should this be:
> win := filepath.Join(b.root, "misc", "dist", "windows")

No, filepath.Join fixes the slashes. It is easier to write and read this
way.

>
http://codereview.appspot.com/5727059/diff/5001/misc/dist/windows/README.txt
> File misc/dist/windows/README.txt (right):
>
>
http://codereview.appspot.com/5727059/diff/5001/misc/dist/windows/README.txt#...
> misc/dist/windows/README.txt:17: - Documentation server shortcut
> checkbox option
> What?
>
> http://codereview.appspot.com/5727059/

[adg, 2012-03-05 21:55:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=32c6683851fb ***

misc/dist: add windows packaging support

R=golang-dev, bsiegert, jdpoirier
CC=golang-dev
http://codereview.appspot.com/5727059