code review 5726062: expvar: add missing locking in String methods

expvar: add missing locking in String methods

[bradfitz, 2012-03-05 18:36:39]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitz, 2012-03-05 18:40:37]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-03-05 18:41:12]

In this version, also changed a new(bytes.Buffer) to var b bytes.Buffer.

On Mon, Mar 5, 2012 at 10:40 AM, <bradfitz@golang.org> wrote:

> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5726062/<http://codereview.appspot.com/5726062/>
>

[rsc, 2012-03-05 18:43:20]

LGTM


On Mon, Mar 5, 2012 at 13:40,  <bradfitz@golang.org> wrote:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/5726062/

[bradfitz, 2012-03-05 18:54:37]

This won't submit.

bradfitz@gopher:~/go/src$ hg p
5726062:
expvar: add missing locking in String methods

Reviewer: golang-dev@googlegroups.com, rsc@golang.org
rsc: LGTM
CC: golang-dev@googlegroups.com
Files:
src/pkg/expvar/expvar.go
bradfitz@gopher:~/go/src$ hg sync
pulling from https://go.googlecode.com/hg
no changes found
bradfitz@gopher:~/go/src$ hg submit 5726062
Issue updated. URL: http://codereview.appspot.com/5726062
created new head
repository tip rolled back to revision 12454 (undo commit)
working directory now based on revision 12023
abort: local repository out of date; must sync before submit
bradfitz@gopher:~/go/src$ hg sync
pulling from https://go.googlecode.com/hg
no changes found
bradfitz@gopher:~/go/src$ hg submit 5726062
Issue updated. URL: http://codereview.appspot.com/5726062
created new head
repository tip rolled back to revision 12454 (undo commit)
working directory now based on revision 12023
abort: local repository out of date; must sync before submit


On Mon, Mar 5, 2012 at 10:43 AM, Russ Cox <rsc@golang.org> wrote:

> LGTM
>
>
> On Mon, Mar 5, 2012 at 13:40,  <bradfitz@golang.org> wrote:
> > Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
> >
> > Please take another look.
> >
> >
> > http://codereview.appspot.com/5726062/
>

[bradfitz, 2012-03-05 19:09:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=b18c189bbc61 ***

expvar: add missing locking in String methods

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5726062