Issue 5725044: code review 5725044: cmd/go: honor buildflags in go test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5725044: code review 5725044: cmd/go: honor buildflags in go test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by remyoudompheng

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc, remy_archlinux.org

Visibility:
Public.

Description

cmd/go: honor buildflags in go test. Fixes issue 3196.

Patch Set 1 #

Patch Set 2 : diff -r 50adb6a9e76c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 50adb6a9e76c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r de155800afc1 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 733971e543a2 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -23 lines)			Patch
M	src/cmd/go/build.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1 2 3 4	3 chunks	+3 lines, -7 lines	0 comments	Download
M	src/cmd/go/testflag.go	View	1	5 chunks	+28 lines, -16 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2012-03-02 09:08:41 UTC) #1

rsc

LGTM Please add at the top of the addBuildFlags function: // NOTE: If you add ...

13 years, 9 months ago (2012-03-05 15:02:12 UTC) #2

remyoudompheng

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.

13 years, 9 months ago (2012-03-05 18:50:03 UTC) #4

remyoudompheng

13 years, 9 months ago (2012-03-05 18:58:33 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=1f28e9df4dc1 ***

cmd/go: honor buildflags in go test.

Fixes issue 3196.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5725044

Expand All Messages | Collapse All Messages