Issue 5725043: code review 5725043: cmd/go: fix test import dependency bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5725043: code review 5725043: cmd/go: fix test import dependency bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/go: fix test import dependency bug Fixes a problem Rob is having with goprotobuf. Cannot add a test because the same case is more broken when using ./ imports. That still needs to be fixed, and is one aspect of issue 3169.

Patch Set 1 #

Patch Set 2 : diff -r 54f0be418491 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 54f0be418491 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 50adb6a9e76c https://code.google.com/p/go/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
M	src/cmd/go/build.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/go/pkg.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/go/test.go	View	1 2 3	6 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 2 months ago (2012-03-02 05:10:07 UTC) #1

rsc

13 years, 2 months ago (2012-03-02 16:27:40 UTC) #3

*** Submitted as 9a9841a31527 ***

cmd/go: fix test import dependency bug

Fixes a problem Rob is having with goprotobuf.
Cannot add a test because the same case is more broken
when using ./ imports.  That still needs to be fixed,
and is one aspect of issue 3169.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5725043

Expand All Messages | Collapse All Messages