Issue 5724044: code review 5724044: build: add GO_ prefix to LDFLAGS and GCFLAGS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5724044: code review 5724044: build: add GO_ prefix to LDFLAGS and GCFLAGS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by niemeyer

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc1, minux1, rsc

Visibility:
Public.

Description

build: add GO_ prefix to LDFLAGS and GCFLAGS Build environments will often define stock LDFLAGS that are not compatible with the gc ld, causing non-obvious failures midway through the build.

Patch Set 2 : code review 5724044: build: add GO_ prefix to LDFLAGS and GCFLAGS #

Patch Set 3 : diff -r fc74ef570a49 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r fc74ef570a49 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8f3e1234e25b https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/make.bash	View	1 2 3	3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-03-02 05:37:13 UTC) #1

rsc1

LGTM http://codereview.appspot.com/5724044/diff/4001/src/make.bash File src/make.bash (right): http://codereview.appspot.com/5724044/diff/4001/src/make.bash#newcode107 src/make.bash:107: mv cmd/dist/dist $GOTOOLDIR/dist While you are here, please ...

13 years, 2 months ago (2012-03-02 05:38:39 UTC) #2

minux1

On Fri, Mar 2, 2012 at 1:37 PM, <n13m3y3r@gmail.com> wrote: > > Description: > build: ...

13 years, 2 months ago (2012-03-02 05:40:46 UTC) #3

rsc

I asked for GO_ prefixes on both. We don't have any other environment variables that ...

13 years, 2 months ago (2012-03-02 05:44:15 UTC) #4

niemeyer

*** Submitted as http://code.google.com/p/go/source/detail?r=8592a2140513 *** build: add GO_ prefix to LDFLAGS and GCFLAGS Build environments ...

13 years, 2 months ago (2012-03-02 05:45:08 UTC) #5

niemeyer

13 years, 2 months ago (2012-03-02 05:46:14 UTC) #6

http://codereview.appspot.com/5724044/diff/4001/src/make.bash
File src/make.bash (right):

http://codereview.appspot.com/5724044/diff/4001/src/make.bash#newcode107
src/make.bash:107: mv cmd/dist/dist $GOTOOLDIR/dist
On 2012/03/02 05:38:39, rsc1 wrote:
> While you are here, please change all the $GOTOOLDIR
> to "$GOTOOLDIR".  Looks like I missed that one.

Done.

Expand All Messages | Collapse All Messages