Issue 5721046: Make ExtensionIdentifier POD.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5721046: Make ExtensionIdentifier POD. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by pliard1

Modified:
11 years, 11 months ago

Reviewers:

Base URL:
http://protobuf.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Make ExtensionIdentifier POD. This change lets us significantly decrease the number of static initializers generated by protoc when Protocol Buffers extensions are used. With this change, ExtensionIdentifier becomes a POD regardless of the runtime mode (lite/heavy runtime). -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER does not need to be provided either to make ExtensionIdentifier a POD. Extensions are now registered lazily the first time that the extension identifier is used (either by calling number() or default_instance()). BUG=351

Patch Set 1 #

Patch Set 2 : Update #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -93 lines)			Patch
M	src/Makefile.am	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_extension.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_extension.cc	View	1	4 chunks	+79 lines, -28 lines	0 comments	Download
M	src/google/protobuf/compiler/cpp/cpp_helpers.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/google/protobuf/extension_set.h	View	1	3 chunks	+127 lines, -65 lines	0 comments	Download
M	vsprojects/extract_includes.bat	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	vsprojects/libprotobuf.vcproj	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	vsprojects/libprotobuf-lite.vcproj	View		1 chunk	+4 lines, -0 lines	0 comments	Download