code review 5720075: net: remove more use of fmt

net: remove more use of fmt

Also add a TODO for the broken *dnsMsg String method.

[bradfitz, 2012-03-05 20:04:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[rsc, 2012-03-05 20:15:36]

LGTM

[borman, 2012-03-05 20:16:33]

http://codereview.appspot.com/5720075/diff/3/src/pkg/net/dnsmsg.go
File src/pkg/net/dnsmsg.go (right):

http://codereview.appspot.com/5720075/diff/3/src/pkg/net/dnsmsg.go#newcode395
src/pkg/net/dnsmsg.go:395: println("net: dns: unknown packing type",
f.Type.String())
Pardon me if I am missing something, but I have always considered it poor
practice for library routines to write output rather than return errors.  If the
output is important then it should be handed back to the caller so it can be
properly displayed.  If it is okay that the message is not displayed to the user
then why have it in here at all?

[rsc, 2012-03-05 20:17:59]

On Mon, Mar 5, 2012 at 15:16,  <borman@google.com> wrote:
> Pardon me if I am missing something, but I have always considered it
> poor practice for library routines to write output rather than return
> errors.  If the output is important then it should be handed back to the
> caller so it can be properly displayed.  If it is okay that the message
> is not displayed to the user then why have it in here at all?

Brad is just replacing uses of fmt, not addressing bigger issues like this one.
This code is soon to be dead.

[bradfitz, 2012-03-05 20:21:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=7dd31c1f40dc ***

net: remove more use of fmt

Also add a TODO for the broken *dnsMsg String method.

R=golang-dev, rsc, borman
CC=golang-dev
http://codereview.appspot.com/5720075