Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(847)

Issue 571030043: Issue 5584: Rehabilitate regtest workflow (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Dan Eble
Modified:
4 years, 5 months ago
Reviewers:
lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5584/ 0. fix repeated test runs for input/regression/midi this is issue 5582 but other changes in this review depend on it the approach is to move the ly files that are the result of converting ly -> midi -> ly into a subdirectory to keep them separate from the ly files produced by lilypond-book 1. fix multiple rules for target collated-files.list 2. don't create the output dir just to remove it 3. include count of added/removed regtests in summary 4. sort changed.txt and ensure a final newline 5. rehabilitate regtest workflow "make test-baseline" now incorporates "make test-clean" "make check" now works as make test-redo was supposed to: changed test cases are re-tested 6. Contributor's Guide updates

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -57 lines) Patch
M Documentation/contributor/programming-work.itexi View 3 chunks +5 lines, -6 lines 0 comments Download
M Documentation/contributor/regressions.itexi View 2 chunks +5 lines, -11 lines 0 comments Download
M GNUmakefile.in View 3 chunks +18 lines, -7 lines 0 comments Download
M input/regression/lilypond-book/GNUmakefile View 2 chunks +2 lines, -6 lines 0 comments Download
M input/regression/midi/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M make/lysdoc-rules.make View 2 chunks +5 lines, -1 line 0 comments Download
M make/lysdoc-targets.make View 1 chunk +3 lines, -1 line 0 comments Download
M make/lysdoc-vars.make View 1 chunk +1 line, -2 lines 0 comments Download
M make/midi-rules.make View 1 chunk +4 lines, -3 lines 0 comments Download
M make/midi-vars.make View 1 chunk +1 line, -1 line 0 comments Download
M scripts/build/output-distance.py View 8 chunks +29 lines, -15 lines 1 comment Download
M stepmake/stepmake/generic-targets.make View 1 chunk +7 lines, -2 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/toplevel-targets.make View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
Dan Eble
4 years, 6 months ago (2019-10-23 14:00:05 UTC) #1
lemzwerg
LGTM, thanks!
4 years, 6 months ago (2019-10-23 17:50:55 UTC) #2
Dan Eble
https://codereview.appspot.com/571030043/diff/579010043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/571030043/diff/579010043/scripts/build/output-distance.py#newcode1050 scripts/build/output-distance.py:1050: return make_row (label, value) if value else '' It ...
4 years, 5 months ago (2019-11-04 18:03:31 UTC) #3
hahnjo
On 2019/11/04 18:03:31, Dan Eble wrote: > https://codereview.appspot.com/571030043/diff/579010043/scripts/build/output-distance.py > File scripts/build/output-distance.py (right): > > https://codereview.appspot.com/571030043/diff/579010043/scripts/build/output-distance.py#newcode1050 ...
4 years, 5 months ago (2019-11-04 18:20:27 UTC) #4
Dan Eble
4 years, 5 months ago (2019-11-04 18:40:45 UTC) #5
On 2019/11/04 18:20:27, hahnjo wrote:
> Sorry, I wanted to test but forgot until now :-( let me know if you wanted a
> second pair of eyes, I'm working on LilyPond right now anyway.

No need to apologize.  Anyway, it probably would have been a challenge to apply
this patch to master until a few hours ago when the revised changes for Issue
5578 made it back in.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b