code review 5710055: go/build: document GOPATH

go/build: document GOPATH

Fixes issue 2332.

[rsc, 2012-03-01 22:33:11]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[remyoudompheng, 2012-03-01 22:38:19]

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:12: // variable, interpreted a a path list appropriate
to the operating system
s/a a/as a/

[gri, 2012-03-01 22:41:16]

LGTM

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:12: // variable, interpreted a a path list appropriate
to the operating system
s/a a/as a/

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:34: // the final element, not the entire path.  That
is, the
s/the final/using the final/ ?

[rsc, 2012-03-01 22:44:59]

Thanks, done.

[gri, 2012-03-01 22:45:41]

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

http://codereview.appspot.com/5710055/diff/4001/src/pkg/go/build/build.go#new...
src/pkg/go/build/build.go:434: // If an error occurs, Import returns a non-nil
error also returns a non-nil
s/also/and also/ ?

weird sentence

[r, 2012-03-01 23:00:22]

LGTM
this is good, but people will see GOPATH through the go command and this text is
not exposed there

[rsc, 2012-03-01 23:01:19]

it's mostly copied from the go command: go help gopath.

[r2, 2012-03-01 23:02:35]

On Mar 2, 2012, at 10:01 AM, Russ Cox wrote:

> it's mostly copied from the go command: go help gopath.

still LGTM

[r2, 2012-03-01 23:03:31]

On Mar 2, 2012, at 10:01 AM, Russ Cox wrote:

> it's mostly copied from the go command: go help gopath.

actually not quite LGTM. at least one of these should refer to the other. if
they're duplicates, fine, but crosslink to aid consistency under development.

[rsc, 2012-03-01 23:17:04]

Hello golang-dev@googlegroups.com, remyoudompheng@gmail.com, gri@golang.org,
r@golang.org, r@google.com (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-03-01 23:24:05]

LGTM for sure

[rsc, 2012-03-01 23:26:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=a8e890a867d2 ***

go/build: document GOPATH

Fixes issue 2332.

R=golang-dev, remyoudompheng, gri, r, r
CC=golang-dev
http://codereview.appspot.com/5710055