Issue 5708046: code review 5708046: devdraw: fix fullscreen on Lion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5708046: code review 5708046: devdraw: fix fullscreen on Lion (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rsc

Modified:
12 years, 2 months ago

Reviewers:

CC:
djeannot24

Visibility:
Public.

Description

devdraw: fix fullscreen on Lion Now, if you full-screen an app running on a secondary screen, it only takes over that monitor. It does not cause the primary screen to disappear. Code by David Jeannot.

Patch Set 1 #

Patch Set 2 : diff -r fe579eab96a1 https://code.google.com/p/plan9port #

Patch Set 3 : diff -r fe579eab96a1 https://code.google.com/p/plan9port #

Patch Set 4 : diff -r fe579eab96a1 https://code.google.com/p/plan9port #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/cmd/devdraw/cocoa-screen.m	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello djeannot24@gmail.com, I'd like you to review this change to https://code.google.com/p/plan9port

12 years, 2 months ago (2012-02-28 18:39:00 UTC) #1

rsc

12 years, 2 months ago (2012-02-28 19:56:17 UTC) #2

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=5b13b9b26de3
***

devdraw: fix fullscreen on Lion

Now, if you full-screen an app running on a secondary
screen, it only takes over that monitor.  It does not cause
the primary screen to disappear.

Code by David Jeannot.

R=djeannot24
http://codereview.appspot.com/5708046

Expand All Messages | Collapse All Messages