Issue 5706043: code review 5706043: net: fix comment on Dial with unixgram

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5706043: code review 5706043: net: fix comment on Dial with unixgram (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by mikio

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

net: fix comment on Dial with unixgram We should use DialUnix or ListenPacket for unixgram networks because Dial doesn't take a local UnixAddr.

Patch Set 1 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 2d7f9ec6c3dc https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/net/dial.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-28 07:53:24 UTC) #1

mikio

12 years, 2 months ago (2012-02-28 22:45:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b4580a3b3331 ***

net: fix comment on Dial with unixgram

We should use DialUnix or ListenPacket for unixgram networks
because Dial doesn't take a local UnixAddr.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5706043

Expand All Messages | Collapse All Messages