Issue 5702050: code review 5702050: all: remove various unused unexported functions and con...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5702050: code review 5702050: all: remove various unused unexported functions and con... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by remyoudompheng

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, minux1, rsc, remy_archlinux.org

Visibility:
Public.

Description

all: remove various unused unexported functions and constants.

Patch Set 1 #

Patch Set 2 : diff -r eabeb88b4bb7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r eabeb88b4bb7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b1838c15bcfa https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -54 lines)			Patch
M	src/pkg/archive/zip/reader.go	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
M	src/pkg/bufio/bufio.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/encoding/json/encode.go	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/pkg/net/http/lex.go	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/pkg/time/format.go	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/pkg/time/time.go	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-28 18:54:02 UTC) #1

minux1

LGTM. Are you using some automatic tool to detect this? Or am I missing something? ...

12 years, 2 months ago (2012-02-28 19:03:24 UTC) #2

remyoudompheng

12 years, 1 month ago (2012-02-28 20:48:18 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=aa03e1f59b18 ***

all: remove various unused unexported functions and constants.

R=golang-dev, minux.ma, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5702050

Expand All Messages | Collapse All Messages