Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2182)

Issue 5701064: code review 5701064: net: no panic on placeholders for netbsd (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by mikio
Modified:
12 years, 1 month ago
Reviewers:
bsiegert
CC:
golang-dev, r
Visibility:
Public.

Description

net: no panic on placeholders for netbsd Perhaps it might be better than panic.

Patch Set 1 #

Patch Set 2 : diff -r 0e8f0096e631 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0e8f0096e631 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0e8f0096e631 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M src/pkg/net/sockoptip_netbsd.go View 1 1 chunk +27 lines, -3 lines 0 comments Download

Messages

Total messages: 4
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-28 01:00:52 UTC) #1
r
LGTM sure
12 years, 1 month ago (2012-02-28 01:40:31 UTC) #2
mikio
*** Submitted as http://code.google.com/p/go/source/detail?r=0ea926cdbb36 *** net: no panic on placeholders for netbsd Perhaps it might ...
12 years, 1 month ago (2012-02-28 01:58:05 UTC) #3
bsiegert
12 years, 1 month ago (2012-02-28 07:49:44 UTC) #4
Nice, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b