code review 5701063: gobuilder: send commit time in RFC3339 format

gobuilder: send commit time in RFC3339 format

[adg, 2012-02-28 00:20:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[gri, 2012-02-28 00:21:27]

LGTM

On Mon, Feb 27, 2012 at 4:20 PM,  <adg@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> gobuilder: send commit time in RFC3339 format
>
> Please review this at http://codereview.appspot.com/5701063/
>
> Affected files:
>  M misc/dashboard/builder/http.go
>
>
> Index: misc/dashboard/builder/http.go
> ===================================================================
> --- a/misc/dashboard/builder/http.go
> +++ b/misc/dashboard/builder/http.go
> @@ -169,7 +169,7 @@
>                "PackagePath": pkg,
>                "Hash":        l.Hash,
>                "ParentHash":  l.Parent,
> -               "Time":        t.Unix() * 1e6, // in microseconds, yuck!
> +               "Time":        t.Format(time.RFC3339),
>                "User":        l.Author,
>                "Desc":        l.Desc,
>        }, nil)
>
>

[adg, 2012-02-28 00:22:02]

*** Submitted as http://code.google.com/p/go/source/detail?r=f7a7f77a4ae2 ***

gobuilder: send commit time in RFC3339 format

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5701063

[dsymonds, 2012-02-28 00:22:34]

LGTM

Hah, oops.