Issue 5700083: code review 5700083: crypto/tls: force OS X target version to 10.6 for API c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5700083: code review 5700083: crypto/tls: force OS X target version to 10.6 for API c...

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by mkrautz

Modified:
12 years, 2 months ago

Reviewers:
rsc

CC:
minux1, rsc, golang-dev

Visibility:
Public.

Description

crypto/tls: force OS X target version to 10.6 for API compatibility This is a band-aid until we can use weak imports with cgo. Fixes issue 3131.

Patch Set 2 : diff -r bf0768b1dece https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r bf0768b1dece https://code.google.com/p/go/ #

Patch Set 4 : diff -r bf0768b1dece https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -24 lines)			Patch
	M	src/pkg/crypto/tls/root_darwin.go	View	1 2	2 chunks	+8 lines, -24 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

http://codereview.appspot.com/5700083/diff/2001/src/pkg/crypto/tls/root_darwin.go File src/pkg/crypto/tls/root_darwin.go (right): http://codereview.appspot.com/5700083/diff/2001/src/pkg/crypto/tls/root_darwin.go#newcode43 src/pkg/crypto/tls/root_darwin.go:43: err = SecKeychainItemExport(cert, kSecFormatX509Cert, kSecItemPemArmour, NULL, &data); Should we ...

12 years, 2 months ago (2012-02-27 18:18:35 UTC) #1

mkrautz

Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2012-02-27 18:37:50 UTC) #2

mkrautz

On 2012/02/27 18:18:35, minux wrote: > http://codereview.appspot.com/5700083/diff/2001/src/pkg/crypto/tls/root_darwin.go > File src/pkg/crypto/tls/root_darwin.go (right): > > http://codereview.appspot.com/5700083/diff/2001/src/pkg/crypto/tls/root_darwin.go#newcode43 > ...

12 years, 2 months ago (2012-02-27 18:38:58 UTC) #3

rsc

12 years, 2 months ago (2012-02-28 16:39:06 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=5411050a8397 ***

crypto/tls: force OS X target version to 10.6 for API compatibility

This is a band-aid until we can use weak imports with cgo.

Fixes issue 3131.

R=minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/5700083

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages