Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 5700060: code review 5700060: runtime: size arena to fit in virtual address space limit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by rsc
Modified:
13 years, 10 months ago
Reviewers:
bradfitzgoog
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: size arena to fit in virtual address space limit For Brad. Now FreeBSD/386 binaries run on nearlyfreespeech.net. Fixes issue 2302.

Patch Set 1 #

Patch Set 2 : diff -r 0fad39944acd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 48651afada16 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r a73ba181cfab https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -1 line) Patch
M src/pkg/runtime/malloc.goc View 1 2 3 4 chunks +10 lines, -1 line 0 comments Download
M src/pkg/runtime/os_freebsd.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/runtime/os_linux.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/sys_freebsd_386.s View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_freebsd_amd64.s View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_linux_386.s View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_linux_amd64.s View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/pkg/runtime/sys_linux_arm.s View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_darwin.c View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_freebsd.c View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_linux.c View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_netbsd.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_openbsd.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_plan9.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/thread_windows.c View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2012-02-24 06:20:01 UTC) #1
r
LGTM http://codereview.appspot.com/5700060/diff/3/src/pkg/runtime/malloc.goc File src/pkg/runtime/malloc.goc (right): http://codereview.appspot.com/5700060/diff/3/src/pkg/runtime/malloc.goc#newcode351 src/pkg/runtime/malloc.goc:351: runtime·printf("runtime: SysReserve returned unaligned address %p asked for ...
13 years, 10 months ago (2012-02-24 08:46:50 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=0d09d40b8f34 *** runtime: size arena to fit in virtual address space limit ...
13 years, 10 months ago (2012-02-24 20:28:53 UTC) #3
bradfitzgoog
13 years, 10 months ago (2012-02-26 08:14:25 UTC) #4
Yay! Thanks!

On Thu, Feb 23, 2012 at 10:20 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: size arena to fit in virtual address space limit
>
> For Brad.
> Now FreeBSD/386 binaries run on nearlyfreespeech.net.
>
> Fixes issue 2302.
>
> Please review this at
http://codereview.appspot.com/**5700060/<http://codereview.appspot.com/5700060/>
>
> Affected files:
>  M src/pkg/runtime/malloc.goc
>  M src/pkg/runtime/os_freebsd.h
>  M src/pkg/runtime/os_linux.h
>  M src/pkg/runtime/runtime.h
>  M src/pkg/runtime/sys_freebsd_**386.s
>  M src/pkg/runtime/sys_freebsd_**amd64.s
>  M src/pkg/runtime/sys_linux_386.**s
>  M src/pkg/runtime/sys_linux_**amd64.s
>  M src/pkg/runtime/sys_linux_arm.**s
>  M src/pkg/runtime/thread_darwin.**c
>  M src/pkg/runtime/thread_**freebsd.c
>  M src/pkg/runtime/thread_linux.c
>  M src/pkg/runtime/thread_netbsd.**c
>  M src/pkg/runtime/thread_**openbsd.c
>  M src/pkg/runtime/thread_plan9.c
>  M src/pkg/runtime/thread_**windows.c
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b