code review 5700057: go/ast: examples for ast.Print, ast.Inspect

go/ast: examples for ast.Print, ast.Inspect

[gri, 2012-02-24 21:14:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-02-24 21:24:43]

http://codereview.appspot.com/5700057/diff/3/src/pkg/go/ast/example_test.go
File src/pkg/go/ast/example_test.go (right):

http://codereview.appspot.com/5700057/diff/3/src/pkg/go/ast/example_test.go#n...
src/pkg/go/ast/example_test.go:33: fmt.Println(x.Value)
please show using/displaying the pos.

[gri, 2012-02-24 21:30:45]

PTAL

On Fri, Feb 24, 2012 at 1:24 PM,  <r@golang.org> wrote:
>
> http://codereview.appspot.com/5700057/diff/3/src/pkg/go/ast/example_test.go
> File src/pkg/go/ast/example_test.go (right):
>
>
http://codereview.appspot.com/5700057/diff/3/src/pkg/go/ast/example_test.go#n...
> src/pkg/go/ast/example_test.go:33: fmt.Println(x.Value)
> please show using/displaying the pos.

Done.

>
> http://codereview.appspot.com/5700057/

[r, 2012-02-24 21:33:57]

LGTM

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.go
File src/pkg/go/ast/example_test.go (right):

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.g...
src/pkg/go/ast/example_test.go:14: func ExampleInspect() {
// ExampleInspect demonstrates how to walk the AST of a Go program.

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.g...
src/pkg/go/ast/example_test.go:22: // create the AST by parsing src
s/c/C/
s/$/./
and so on throughout

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.g...
src/pkg/go/ast/example_test.go:55: func ExamplePrint() {
// ExamplePrint shows what an AST looks like when printed for debugging.

[gri, 2012-02-24 21:44:38]

*** Submitted as http://code.google.com/p/go/source/detail?r=8866952aef97 ***

go/ast: examples for ast.Print, ast.Inspect

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5700057

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.go
File src/pkg/go/ast/example_test.go (right):

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.g...
src/pkg/go/ast/example_test.go:14: func ExampleInspect() {
On 2012/02/24 21:33:57, r wrote:
> // ExampleInspect demonstrates how to walk the AST of a Go program.

Done.

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.g...
src/pkg/go/ast/example_test.go:22: // create the AST by parsing src
On 2012/02/24 21:33:57, r wrote:
> s/c/C/
> s/$/./
> and so on throughout

Done.

http://codereview.appspot.com/5700057/diff/2002/src/pkg/go/ast/example_test.g...
src/pkg/go/ast/example_test.go:55: func ExamplePrint() {
On 2012/02/24 21:33:57, r wrote:
> // ExamplePrint shows what an AST looks like when printed for debugging.

Done.