Issue 5699098: Improve readability of search menu text

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5699098: Improve readability of search menu text (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by nicholasbishop

Modified:
12 years, 2 months ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

The search menu used for selecting brushes (as well as brush textures in sculpt mode) draws text directly over preview icons. Depending on what the icon is, this can make the text very hard to read. This patch adds a solid background between the icon and text. Example: http://www.pasteall.org/pic/show.php?id=27401 It could probably be further improved aesthetically, but at least it is readable with this.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
		source/blender/editors/interface/interface_widgets.c	View		2 chunks	+20 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nicholasbishop

12 years, 2 months ago (2012-02-28 20:47:44 UTC) #3

On 2012/02/28 14:42:57, brechtvl wrote:
> LGTM.

Thanks, committed as r44532.

Expand All Messages | Collapse All Messages