Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
LGTM http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go File src/pkg/archive/zip/reader.go (right): http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go#ne... src/pkg/archive/zip/reader.go:300: return nil, errors.New("invalid comment length") "zip: ..." http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go#ne... src/pkg/archive/zip/reader.go:323: c := *b c is a bit of a weird variable name. I'd use a temporary named v instead. I think this reads easier: v := binary.LittleEndian.Uint16(*b) *b = (*b)[2:] return v http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go#ne... src/pkg/archive/zip/reader.go:329: c := *b likewise
*** Submitted as http://code.google.com/p/go/source/detail?r=4723d6672df6 *** archive/zip: use encoding/binary again, add readBuf helper R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5699097 http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go File src/pkg/archive/zip/reader.go (right): http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go#ne... src/pkg/archive/zip/reader.go:300: return nil, errors.New("invalid comment length") On 2012/02/27 22:34:21, bradfitzgoog wrote: > "zip: ..." Done. http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go#ne... src/pkg/archive/zip/reader.go:323: c := *b On 2012/02/27 22:34:21, bradfitzgoog wrote: > c is a bit of a weird variable name. I'd use a temporary named v instead. I > think this reads easier: > > v := binary.LittleEndian.Uint16(*b) > *b = (*b)[2:] > return v Done. http://codereview.appspot.com/5699097/diff/1/src/pkg/archive/zip/reader.go#ne... src/pkg/archive/zip/reader.go:329: c := *b On 2012/02/27 22:34:21, bradfitzgoog wrote: > likewise Done.