Issue 5697069: code review 5697069: testing: add -test.example flag to control execution of...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5697069: code review 5697069: testing: add -test.example flag to control execution of... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:
rsc, r2

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

testing: add -test.example flag to control execution of examples Also, don't run examples if -test.run is set.

Patch Set 2 : diff -r cc4ffa82948b https://code.google.com/p/go/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
M	src/cmd/go/test.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/go/testflag.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/testing/example.go	View		3 chunks	+15 lines, -1 line	0 comments	Download
M	src/pkg/testing/testing.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 3 months ago (2012-02-27 01:04:51 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/5697069/diff/1/src/cmd/go/testflag.go File src/cmd/go/testflag.go (right): http://codereview.appspot.com/5697069/diff/1/src/cmd/go/testflag.go#newcode31 src/cmd/go/testflag.go:31: -examples="": passes -test.examples to test s/(example)s/\1/g

13 years, 3 months ago (2012-02-27 01:41:13 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=26372a25493b *** testing: add -test.example flag to control execution of examples Also, ...

13 years, 3 months ago (2012-02-27 01:49:14 UTC) #3

rsc

Given that the examples all begin with Example and the tests all begin with Test ...

13 years, 3 months ago (2012-02-27 15:34:04 UTC) #4

13 years, 3 months ago (2012-02-27 20:49:40 UTC) #5

On 28/02/2012, at 2:34 AM, Russ Cox wrote:

> Given that the examples all begin with Example and
> the tests all begin with Test (and that the examples are
> serving as tests), I wonder if it would have been better
> to apply -run to both.

i did say, this time for sure, which means not.

Expand All Messages | Collapse All Messages