code review 5697062: go/printer: fix printing of variadic function calls

go/printer: fix printing of variadic function calls

Fixes issue 3130.

[ality, 2012-02-26 03:19:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[ality, 2012-02-26 03:20:47]

gri,

Do you want me to put the test for this in
go/printer or cmd/gofmt?

Thanks,
  Anthony

[gri, 2012-02-27 20:21:35]

The test should be in go/printer - we always want to test this. Please
wait though, I will have a look at this later this afternoon.
- gri

On Sat, Feb 25, 2012 at 7:20 PM, Anthony Martin <ality@pbrane.org> wrote:
> gri,
>
> Do you want me to put the test for this in
> go/printer or cmd/gofmt?
>
> Thanks,
>  Anthony

[gri, 2012-02-27 21:19:42]

Please add the tests below to the end of testdata/expressions.input:

// Handle multi-line argument lists ending in ... correctly.
// Was issue 3130.
func _ () {
	_ = append(s, a...)
	_ = append(
		s, a...)
	_ = append(s,
		a...)
	_ = append(
		s,
		a...)
	_ = append(s, a...,
	)
	_ = append(
		s, a...,
	)
	_ = append(s,
		a...,
	)
	_ = append(
		s,
		a...,
	)
}

http://codereview.appspot.com/5697062/diff/1002/src/pkg/go/printer/nodes.go
File src/pkg/go/printer/nodes.go (right):

http://codereview.appspot.com/5697062/diff/1002/src/pkg/go/printer/nodes.go#n...
src/pkg/go/printer/nodes.go:808: p.exprList(x.Lparen, x.Args, depth,
commaSep|commaTerm, multiLine, x.Ellipsis)
s/|commaTerm//

http://codereview.appspot.com/5697062/diff/1002/src/pkg/go/printer/nodes.go#n...
src/pkg/go/printer/nodes.go:810: if *multiLine {
please make this:

if x.Rparen.IsValid() && p.lineFor(x.Ellipsis) < p.lineFor(x.Rparen) {
	p.print(token.COMMA, formfeed)
}

multiLine is not correct here (it says nothing about the position of the )
relative to ...

[ality, 2012-02-27 21:51:16]

PTAL

[gri, 2012-02-27 21:56:24]

LGTM

Thanks for tracking this down!
- gri

[gri, 2012-02-27 21:56:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=807ac3421bff ***

go/printer: fix printing of variadic function calls

Fixes issue 3130.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5697062

Committer: Robert Griesemer <gri@golang.org>