Issue 5696069: CG: Use latest convert-ly for LSR updates (fix 2346)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5696069: CG: Use latest convert-ly for LSR updates (fix 2346) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by janek

Modified:
12 years, 1 month ago

Reviewers:
Graham Percival, Julien Rioux

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

CG: Use latest convert-ly for LSR updates (fix 2346) Suggested by Thomas Morley: Use convert-ly from latest development release for LSR updates

Patch Set 2 : remove item #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	Documentation/contributor/lsr-work.itexi	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

janek

Please review. I'm very busy with GSoC now, so if you identify deficiencies, please write ...

12 years, 1 month ago (2012-02-25 07:18:46 UTC) #1

Julien Rioux

One suggestion. Regards, Julien http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi File Documentation/contributor/lsr-work.itexi (right): http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi#newcode302 Documentation/contributor/lsr-work.itexi:302: @item This isn't per se ...

12 years, 1 month ago (2012-02-25 12:52:22 UTC) #2

Graham Percival

http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi File Documentation/contributor/lsr-work.itexi (right): http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-work.itexi#newcode302 Documentation/contributor/lsr-work.itexi:302: @item On 2012/02/25 12:52:22, Julien Rioux wrote: > This ...

12 years, 1 month ago (2012-02-27 13:04:03 UTC) #3

janek

12 years, 1 month ago (2012-02-27 23:10:45 UTC) #4

New patch set.

http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-wo...
File Documentation/contributor/lsr-work.itexi (right):

http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-wo...
Documentation/contributor/lsr-work.itexi:302: @item
On 2012/02/25 12:52:22, Julien Rioux wrote:
> This isn't per se a new @item in terms of steps to be performed. I suggest
> merging it with the previous @item.

Done.

http://codereview.appspot.com/5696069/diff/1/Documentation/contributor/lsr-wo...
Documentation/contributor/lsr-work.itexi:302: @item
On 2012/02/27 13:04:03, Graham Percival wrote:
> On 2012/02/25 12:52:22, Julien Rioux wrote:
> > This isn't per se a new @item in terms of steps to be performed. I suggest
> > merging it with the previous @item.
> 
> Either that, or split up the previous -- have a new @teim for download,
another
> for extract, and another for convert-ly.

ok, i merged it.

Expand All Messages | Collapse All Messages