Issue 5695080: code review 5695080: encoding/binary: better example

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5695080: code review 5695080: encoding/binary: better example (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 2 months ago

Reviewers:
r2

CC:
golang-dev, adg

Visibility:
Public.

Description

encoding/binary: better example leave that joke to Java.

Patch Set 1 #

Patch Set 2 : diff -r 4723d6672df6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4723d6672df6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4723d6672df6 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/encoding/binary/example_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-27 23:08:38 UTC) #1

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=581b0fcafe5a *** encoding/binary: better example leave that joke to Java. R=golang-dev, adg ...

12 years, 2 months ago (2012-02-27 23:15:30 UTC) #3

12 years, 2 months ago (2012-02-27 23:53:59 UTC) #4

On Feb 28, 2012, at 10:15 AM, bradfitz@golang.org wrote:

> *** Submitted as
> http://code.google.com/p/go/source/detail?r=581b0fcafe5a ***
> 
> encoding/binary: better example
> 
> leave that joke to Java.
> 
> R=golang-dev, adg
> CC=golang-dev
> http://codereview.appspot.com/5695080
> 
> 
> http://codereview.appspot.com/5695080/

i'm a fan of BADC0C0A myself.

-rob

Expand All Messages | Collapse All Messages