Issue 5695059: Improving \harmonicBy... functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5695059: Improving \harmonicBy... functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by marc

Modified:
12 years, 2 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Improving \harmonicBy... functions These functions work now as expected for guitar music. We have dotted harmonics and mixed harmonic note heads.

Patch Set 2 : Changed 'above' to 'at' in description #

Total comments: 1

Patch Set 3 : Simplify commands according to David's proposals #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -28 lines)			Patch
	M	ly/music-functions-init.ly	View	1 2	1 chunk	+34 lines, -28 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

http://codereview.appspot.com/5695059/diff/1001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/5695059/diff/1001/ly/music-functions-init.ly#newcode393 ly/music-functions-init.ly:393: (make-harmonic As each #{...#} carries a bit of overhead, ...

12 years, 2 months ago (2012-02-24 14:32:31 UTC) #1

marc

12 years, 2 months ago (2012-02-24 19:50:08 UTC) #2

Am 24.02.2012 15:32, schrieb dak@gnu.org:
>
> http://codereview.appspot.com/5695059/diff/1001/ly/music-functions-init.ly 
>
> File ly/music-functions-init.ly (right):
>
>
http://codereview.appspot.com/5695059/diff/1001/ly/music-functions-init.ly#ne...

>
> ly/music-functions-init.ly:393: (make-harmonic
> As each #{...#} carries a bit of overhead, there is little point in
> having two of them wrapped in make-sequential-music.  Just make a single
> #{ ... #} instead of the whole make-sequential-music and splice
> $(make-harmonic ...) in the middle.
Ok, done.
>
> http://codereview.appspot.com/5695059/
>

Expand All Messages | Collapse All Messages