Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 5693065: code review 5693065: net: add stubs for NetBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bsiegert
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

net: add stubs for NetBSD This fixes the build of package net for GOOS=NetBSD. Of course, a real implementation would be even better.

Patch Set 1 #

Patch Set 2 : diff -r 0fa62412dbdd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0fa62412dbdd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A src/pkg/net/sockoptip_netbsd.go View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
bsiegert
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-25 17:53:10 UTC) #1
r
LGTM
12 years, 1 month ago (2012-02-28 00:27:47 UTC) #2
r
12 years, 1 month ago (2012-02-28 00:28:14 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=72530ac849d0 ***

net: add stubs for NetBSD

This fixes the build of package net for GOOS=NetBSD.
Of course, a real implementation would be even better.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5693065

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b