code review 5693057: reflect.DeepEqual: don't panic comparing functions

reflect.DeepEqual: don't panic comparing functions
Functions are equal iff they are both nil.

Fixes issue 3122.

[r, 2012-02-24 05:21:48]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[dsymonds, 2012-02-24 05:24:25]

I wonder whether it should default the other way (i.e. consider two
non-nil funcs equal). Otherwise DeepEqual is a bit useless if you have
just a single func field in your type structure.


Dave.

[rsc, 2012-02-24 05:24:53]

LGTM as is.

I would rather have false negatives than false positives.

[r, 2012-02-24 05:25:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=9c97f1591f2c ***

reflect.DeepEqual: don't panic comparing functions
Functions are equal iff they are both nil.

Fixes issue 3122.

R=golang-dev, dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5693057

[r2, 2012-02-24 05:26:04]

On Feb 24, 2012, at 4:24 PM, Russ Cox wrote:

> LGTM as is.
> 
> I would rather have false negatives than false positives.

agreed. this way we catch uses of DeepEqual that can't work.