Issue 5693052: code review 5693052: cmd/cc: grow some global arrays

Issue 5693052: code review 5693052: cmd/cc: grow some global arrays (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

cmd/cc: grow some global arrays Avoids global array buffer overflows if they are indexed using some of the values between NTYPE and NALLTYPE. It is entirely likely that not all of these are necessary, but this is the C compiler and not worth worrying much about. This change takes up only a few more bytes of memory and makes the behavior deterministic. Fixes issue 3078.

Patch Set 1 #

Patch Set 2 : diff -r ccbda0007400 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ccbda0007400 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r bc7a84869f47 https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -29 lines)			Patch
M	src/cmd/cc/cc.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/cc/com64.c	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/cc/funct.c	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/cc/sub.c	View	1 2 3	8 chunks	+24 lines, -24 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-02-24 00:45:48 UTC) #1

bradfitz

LGTM On Fri, Feb 24, 2012 at 11:45 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...

13 years, 2 months ago (2012-02-24 00:47:11 UTC) #2

LGTM

On Fri, Feb 24, 2012 at 11:45 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/cc: grow some global arrays
>
> Avoids global array buffer overflows if they are
> indexed using some of the values between NTYPE
> and NALLTYPE.  It is entirely likely that not all of these
> are necessary, but this is the C compiler and not worth
> worrying much about.  This change takes up only a
> few more bytes of memory and makes the behavior
> deterministic.
>
> Fixes issue 3078.
>
> Please review this at
http://codereview.appspot.com/**5693052/<http://codereview.appspot.com/5693052/>
>
> Affected files:
>  M src/cmd/cc/cc.h
>  M src/cmd/cc/com64.c
>  M src/cmd/cc/funct.c
>  M src/cmd/cc/sub.c
>
>
> Index: src/cmd/cc/cc.h
> ==============================**==============================**=======
> --- a/src/cmd/cc/cc.h
> +++ b/src/cmd/cc/cc.h
> @@ -517,8 +517,8 @@
>  EXTERN char*   thestring;
>  EXTERN Type*   thisfn;
>  EXTERN int32   thunk;
> -EXTERN Type*   types[NTYPE];
> -EXTERN Type*   fntypes[NTYPE];
> +EXTERN Type*   types[NALLTYPE];
> +EXTERN Type*   fntypes[NALLTYPE];
>  EXTERN Node*   initlist;
>  EXTERN Term    term[NTERM];
>  EXTERN int     nterm;
> Index: src/cmd/cc/com64.c
> ==============================**==============================**=======
> --- a/src/cmd/cc/com64.c
> +++ b/src/cmd/cc/com64.c
> @@ -96,7 +96,7 @@
>
>  Node*  nodvasop;
>
> -char   etconv[NTYPE];  /* for _vasop */
> +char   etconv[NALLTYPE];       /* for _vasop */
>  Init   initetconv[] =
>  {
>        TCHAR,          1,      0,
> Index: src/cmd/cc/funct.c
> ==============================**==============================**=======
> --- a/src/cmd/cc/funct.c
> +++ b/src/cmd/cc/funct.c
> @@ -46,7 +46,7 @@
>  };
>
>  Ftab   ftabinit[OEND];
> -Gtab   gtabinit[NTYPE];
> +Gtab   gtabinit[NALLTYPE];
>
>  int
>  isfunct(Node *n)
> @@ -350,7 +350,7 @@
>        diag(Z, "dclfunct bad %T %s\n", t, s->name);
>  }
>
> -Gtab   gtabinit[NTYPE] =
> +Gtab   gtabinit[NALLTYPE] =
>  {
>        TCHAR,          "c",
>        TUCHAR,         "uc",
> Index: src/cmd/cc/sub.c
> ==============================**==============================**=======
> --- a/src/cmd/cc/sub.c
> +++ b/src/cmd/cc/sub.c
> @@ -1538,92 +1538,92 @@
>        OEQ, ONE, OLS, OLS, OLO, OLO, OHS, OHS, OHI, OHI,
>  };
>
> -uchar  typei[NTYPE];
> +uchar  typei[NALLTYPE];
>  int    typeiinit[] =
>  {
>        TCHAR, TUCHAR, TSHORT, TUSHORT, TINT, TUINT, TLONG, TULONG, TVLONG,
> TUVLONG, -1,
>  };
> -uchar  typeu[NTYPE];
> +uchar  typeu[NALLTYPE];
>  int    typeuinit[] =
>  {
>        TUCHAR, TUSHORT, TUINT, TULONG, TUVLONG, TIND, -1,
>  };
>
> -uchar  typesuv[NTYPE];
> +uchar  typesuv[NALLTYPE];
>  int    typesuvinit[] =
>  {
>        TVLONG, TUVLONG, TSTRUCT, TUNION, -1,
>  };
>
> -uchar  typeilp[NTYPE];
> +uchar  typeilp[NALLTYPE];
>  int    typeilpinit[] =
>  {
>        TINT, TUINT, TLONG, TULONG, TIND, -1
>  };
>
> -uchar  typechl[NTYPE];
> -uchar  typechlv[NTYPE];
> -uchar  typechlvp[NTYPE];
> +uchar  typechl[NALLTYPE];
> +uchar  typechlv[NALLTYPE];
> +uchar  typechlvp[NALLTYPE];
>  int    typechlinit[] =
>  {
>        TCHAR, TUCHAR, TSHORT, TUSHORT, TINT, TUINT, TLONG, TULONG, -1,
>  };
>
> -uchar  typechlp[NTYPE];
> +uchar  typechlp[NALLTYPE];
>  int    typechlpinit[] =
>  {
>        TCHAR, TUCHAR, TSHORT, TUSHORT, TINT, TUINT, TLONG, TULONG, TIND,
> -1,
>  };
>
> -uchar  typechlpfd[NTYPE];
> +uchar  typechlpfd[NALLTYPE];
>  int    typechlpfdinit[] =
>  {
>        TCHAR, TUCHAR, TSHORT, TUSHORT, TINT, TUINT, TLONG, TULONG, TFLOAT,
> TDOUBLE, TIND, -1,
>  };
>
> -uchar  typec[NTYPE];
> +uchar  typec[NALLTYPE];
>  int    typecinit[] =
>  {
>        TCHAR, TUCHAR, -1
>  };
>
> -uchar  typeh[NTYPE];
> +uchar  typeh[NALLTYPE];
>  int    typehinit[] =
>  {
>        TSHORT, TUSHORT, -1,
>  };
>
> -uchar  typeil[NTYPE];
> +uchar  typeil[NALLTYPE];
>  int    typeilinit[] =
>  {
>        TINT, TUINT, TLONG, TULONG, -1,
>  };
>
> -uchar  typev[NTYPE];
> +uchar  typev[NALLTYPE];
>  int    typevinit[] =
>  {
>        TVLONG, TUVLONG, -1,
>  };
>
> -uchar  typefd[NTYPE];
> +uchar  typefd[NALLTYPE];
>  int    typefdinit[] =
>  {
>        TFLOAT, TDOUBLE, -1,
>  };
>
> -uchar  typeaf[NTYPE];
> +uchar  typeaf[NALLTYPE];
>  int    typeafinit[] =
>  {
>        TFUNC, TARRAY, -1,
>  };
>
> -uchar  typesu[NTYPE];
> +uchar  typesu[NALLTYPE];
>  int    typesuinit[] =
>  {
>        TSTRUCT, TUNION, -1,
>  };
>
> -int32  tasign[NTYPE];
> +int32  tasign[NALLTYPE];
>  Init   tasigninit[] =
>  {
>        TCHAR,          BNUMBER,        0,
> @@ -1644,7 +1644,7 @@
>        -1,             0,              0,
>  };
>
> -int32  tasadd[NTYPE];
> +int32  tasadd[NALLTYPE];
>  Init   tasaddinit[] =
>  {
>        TCHAR,          BNUMBER,        0,
> @@ -1663,7 +1663,7 @@
>        -1,             0,              0,
>  };
>
> -int32  tcast[NTYPE];
> +int32  tcast[NALLTYPE];
>  Init   tcastinit[] =
>  {
>        TCHAR,          BNUMBER|BIND|BVOID,     0,
> @@ -1685,7 +1685,7 @@
>        -1,             0,                      0,
>  };
>
> -int32  tadd[NTYPE];
> +int32  tadd[NALLTYPE];
>  Init   taddinit[] =
>  {
>        TCHAR,          BNUMBER|BIND,   0,
> @@ -1704,7 +1704,7 @@
>        -1,             0,              0,
>  };
>
> -int32  tsub[NTYPE];
> +int32  tsub[NALLTYPE];
>  Init   tsubinit[] =
>  {
>        TCHAR,          BNUMBER,        0,
> @@ -1723,7 +1723,7 @@
>        -1,             0,              0,
>  };
>
> -int32  tmul[NTYPE];
> +int32  tmul[NALLTYPE];
>  Init   tmulinit[] =
>  {
>        TCHAR,          BNUMBER,        0,
> @@ -1741,7 +1741,7 @@
>        -1,             0,              0,
>  };
>
> -int32  tand[NTYPE];
> +int32  tand[NALLTYPE];
>  Init   tandinit[] =
>  {
>        TCHAR,          BINTEGER,       0,
> @@ -1757,7 +1757,7 @@
>        -1,             0,              0,
>  };
>
> -int32  trel[NTYPE];
> +int32  trel[NALLTYPE];
>  Init   trelinit[] =
>  {
>        TCHAR,          BNUMBER,        0,
>
>
>

rsc

13 years, 2 months ago (2012-02-24 03:45:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7263bfdac502 ***

cmd/cc: grow some global arrays

Avoids global array buffer overflows if they are
indexed using some of the values between NTYPE
and NALLTYPE.  It is entirely likely that not all of these
are necessary, but this is the C compiler and not worth
worrying much about.  This change takes up only a
few more bytes of memory and makes the behavior
deterministic.

Fixes issue 3078.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5693052

Expand All Messages | Collapse All Messages