Delkey for button reset problem

Sorry for creating a new issue but for some reason old one (http://codereview.appspot.com/4535083/) fails and throws an error when I try to upload new patch set.

Basically, I've seen some complaints on bf-commiters mailing list that use of Del key under Node editor instead of field reset actually deletes active node. So, this patch changes Delkey to Backspace key. Again, I suggest that sole Backspace key should reset only active field and Ctrl+Backspace should reset a whole active array.

[kungfoobar_gmail.com, 2012-02-23 13:52:41]

Will this also work for any input field? I used to press zero for
resetting fields (but it has some bugs regarding undo) but it seems it
was removed.



2012/2/23  <blend.factory@gmail.com>:
> Reviewers: bf-codereview_blender.org, bf-committers_blender.org,
>
> Description:
> Sorry for creating a new issue but for some reason old one
> (http://codereview.appspot.com/4535083/) fails and throws an error when
> I try to upload new patch set.
>
> Basically, I've seen some complaints on bf-commiters mailing list that
> use of Del key under Node editor instead of field reset actually deletes
> active node. So, this patch changes Delkey to Backspace key. Again, I
> suggest that sole Backspace key should reset only active field and
> Ctrl+Backspace should reset a whole active array.
>
> Please review this at http://codereview.appspot.com/5693045/
>
> Affected files:
>   source/blender/editors/interface/interface_handlers.c
>
>
> Index: source/blender/editors/interface/interface_handlers.c
> ===================================================================
> --- source/blender/editors/interface/interface_handlers.c       (revision
44356)
> +++ source/blender/editors/interface/interface_handlers.c       (working copy)
> @@ -4767,10 +4767,10 @@
>                }
>                /* reset to default */
>                /* XXX hardcoded keymap check.... */
> -               else if(ELEM(event->type, DELKEY, PADPERIOD) && event->val ==
KM_PRESS) {
> -                       /* ctrl+del - reset active button; del - reset a whole
array*/
> +               else if(event->type == BACKSPACEKEY && event->val == KM_PRESS)
{
> +                       /* backspace = reset active button; ctrl+backspace =
reset a whole
> array*/
>                        if (!(ELEM3(but->type, HSVCIRCLE, HSVCUBE, HISTOGRAM)))
> -                               ui_set_but_default(C, !event->ctrl);
> +                               ui_set_but_default(C, event->ctrl);
>                }
>                /* handle menu */
>                else if(event->type == RIGHTMOUSE && event->val == KM_PRESS) {
>
>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers@blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers

[Damir Prebeg, 2012-02-23 17:53:35]

That zero key was replaced 8 months ago with del key and undo bug was
fixed. So yes, currently del key should work on any field.
But problem is that, if you use del key in the node editor, it'll
delete active node. Until that that key becomes customizable, with
this patch I suggest it should be replaced with hardcoded backspace.

On 23 February 2012 14:52, Alberto Torres <kungfoobar@gmail.com> wrote:
> Will this also work for any input field? I used to press zero for
> resetting fields (but it has some bugs regarding undo) but it seems it
> was removed.
>
>
>
> 2012/2/23  <blend.factory@gmail.com>:
>> Reviewers: bf-codereview_blender.org, bf-committers_blender.org,
>>
>> Description:
>> Sorry for creating a new issue but for some reason old one
>> (http://codereview.appspot.com/4535083/) fails and throws an error when
>> I try to upload new patch set.
>>
>> Basically, I've seen some complaints on bf-commiters mailing list that
>> use of Del key under Node editor instead of field reset actually deletes
>> active node. So, this patch changes Delkey to Backspace key. Again, I
>> suggest that sole Backspace key should reset only active field and
>> Ctrl+Backspace should reset a whole active array.
>>
>> Please review this at http://codereview.appspot.com/5693045/
>>
>> Affected files:
>>   source/blender/editors/interface/interface_handlers.c
>>
>>
>> Index: source/blender/editors/interface/interface_handlers.c
>> ===================================================================
>> --- source/blender/editors/interface/interface_handlers.c       (revision
44356)
>> +++ source/blender/editors/interface/interface_handlers.c       (working
copy)
>> @@ -4767,10 +4767,10 @@
>>                }
>>                /* reset to default */
>>                /* XXX hardcoded keymap check.... */
>> -               else if(ELEM(event->type, DELKEY, PADPERIOD) && event->val ==
KM_PRESS) {
>> -                       /* ctrl+del - reset active button; del - reset a
whole array*/
>> +               else if(event->type == BACKSPACEKEY && event->val ==
KM_PRESS) {
>> +                       /* backspace = reset active button; ctrl+backspace =
reset a whole
>> array*/
>>                        if (!(ELEM3(but->type, HSVCIRCLE, HSVCUBE,
HISTOGRAM)))
>> -                               ui_set_but_default(C, !event->ctrl);
>> +                               ui_set_but_default(C, event->ctrl);
>>                }
>>                /* handle menu */
>>                else if(event->type == RIGHTMOUSE && event->val == KM_PRESS) {
>>
>>
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers@blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers

[brechtvl, 2012-02-29 14:05:15]

LGTM, patch committed.

[brechtvl, 2012-02-29 14:08:21]

Forgot to say, I do disagree with swapping the ctrl behavior though, imo it's
more common to want to clear all the fields in an array.