[ASan] Intercept functions on Windows - first version

[ASan] Intercept functions on Windows - first version

Committed as http://llvm.org/viewvc/llvm-project?view=rev&revision=151161

[timurrrr_at_google_com, 2012-02-22 13:04:16]

Hi Alexander, Evgeniy,

Can you please review this patch?
It adds some basic support for function interception on Windows.

Thanks,
Timur

[samsonov, 2012-02-22 13:16:05]

On 2012/02/22 13:04:16, timurrrr_at_google_com wrote:
> Hi Alexander, Evgeniy,
> 
> Can you please review this patch?
> It adds some basic support for function interception on Windows.

IMO InitializeAllInterceptors() really does look horrible now :)
I think we need to use functions like:
InitializeSignalInterceptors()
InitializePthreadInterceptors()
InitializeGCDInterceptors()
and so on. Probably these functions can be defined in their own .cc file, but
even now they may simplify things.

Also, what about using if (ASAN_WINDOWS)?

> Thanks,
> Timur

[samsonov, 2012-02-22 13:40:11]

On Wed, Feb 22, 2012 at 5:16 PM, <samsonov@google.com> wrote:

> On 2012/02/22 13:04:16, timurrrr_at_google_com wrote:
>
>> Hi Alexander, Evgeniy,
>>
>
>  Can you please review this patch?
>> It adds some basic support for function interception on Windows.
>>
>
> IMO InitializeAllInterceptors() really does look horrible now :)
> I think we need to use functions like:
> InitializeSignalInterceptors()
> InitializePthreadInterceptors(**)
> InitializeGCDInterceptors()
> and so on. Probably these functions can be defined in their own .cc
> file, but even now they may simplify things.
>
> Also, what about using if (ASAN_WINDOWS)?
>

omg, if (ASAN_WINDOWS) can be a problem as we'll still need to resolve
symbols
that can be undefined on a given os.


>
>  Thanks,
>> Timur
>>
>
>
>
>
http://codereview.appspot.com/**5690065/<http://codereview.appspot.com/5690065/>
>



-- 
Alexey Samsonov
Software Engineer, Moscow
samsonov@google.com

[glider, 2012-02-22 13:55:40]

LGTM

[Evgeniy Stepanov, 2012-02-22 13:56:13]

lgtm

[timurrrr_at_google_com, 2012-02-22 14:01:40]

On 2012/02/22 13:16:05, samsonov wrote:
> IMO InitializeAllInterceptors() really does look horrible now :)
It's less than 100LOC now

> I think we need to use functions like:
> InitializeSignalInterceptors()
> InitializePthreadInterceptors()
> InitializeGCDInterceptors()
> and so on. Probably these functions can be defined in their own .cc file, but
> even now they may simplify things.
I agree, but not clear how to do this,
especially since we plan to introduce something like
asan_interceptors_{win,posix}.cc later.
Since these functions you suggest will be around 10-20LOC each I'd rather wait a
bit until it's clear how we do platform-specific interceptors in the future.

> Also, what about using if (ASAN_WINDOWS)?
[per offline chat]
We'll need to compile non-Windows interceptors then, otherwise real_X will not
be defined.
I don't want to inject pthread_create just for a bit of extra code readability
:)
 
> > Thanks,
> > Timur

[timurrrr_at_google_com, 2012-02-22 14:04:38]

> LGTM
r151161, thanks!