Issue 5689067: code review 5689067: ld: get symbol table letters right

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5689067: code review 5689067: ld: get symbol table letters right (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by rsc

Modified:
13 years, 2 months ago

Reviewers:
r

CC:
golang-dev

Visibility:
Public.

ld: get symbol table letters right Have to assign them before we create the symbol table. ARM debugging.

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -21 lines)			Patch
M	src/cmd/5l/asm.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/ld/data.c	View	1	4 chunks	+25 lines, -15 lines	0 comments	Download
M	src/cmd/ld/lib.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/symtab.c	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download

Total messages: 3

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-02-22 06:30:02 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=f426a254673e *** ld: get symbol table letters right Have to assign them ...

13 years, 2 months ago (2012-02-22 06:30:07 UTC) #2

LGTM
this time for sure!