Issue 5689057: AddressSanitizer: Don't include GrandCentralDispatch headers in asan headers on Mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5689057: AddressSanitizer: Don't include GrandCentralDispatch headers in asan headers on Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by samsonov

Modified:
12 years, 2 months ago

Reviewers:
ramosian.glider, eugeni.stepanov, glider

CC:
llvm-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/asan/

Visibility:
Public.

More Reviews

Description

AddressSanitizer: Don't include GrandCentralDispatch headers in asan headers on Mac

Patch Set 1 #

Total comments: 3

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	asan_mac.h	View		3 chunks	+13 lines, -6 lines	3 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

eugeni.stepanov

lgtm http://codereview.appspot.com/5689057/diff/1/asan_mac.h File asan_mac.h (right): http://codereview.appspot.com/5689057/diff/1/asan_mac.h#newcode38 asan_mac.h:38: typedef void* dispatch_group_t; Not a big deal, but ...

12 years, 2 months ago (2012-02-21 08:24:11 UTC) #3

glider

http://codereview.appspot.com/5689057/diff/1/asan_mac.h File asan_mac.h (right): http://codereview.appspot.com/5689057/diff/1/asan_mac.h#newcode38 asan_mac.h:38: typedef void* dispatch_group_t; On 2012/02/21 08:24:11, eugeni.stepanov wrote: > ...

12 years, 2 months ago (2012-02-21 08:34:55 UTC) #4

samsonov

12 years, 2 months ago (2012-02-21 08:36:46 UTC) #5

r151044

http://codereview.appspot.com/5689057/diff/1/asan_mac.h
File asan_mac.h (right):

http://codereview.appspot.com/5689057/diff/1/asan_mac.h#newcode38
asan_mac.h:38: typedef void* dispatch_group_t;
On 2012/02/21 08:34:55, glider wrote:
> On 2012/02/21 08:24:11, eugeni.stepanov wrote:
> > Not a big deal, but I would just use void* in the function signatures.
> 
> Please no. We'll end up having (void*, void*, void*) function prototypes and
> soon won't be able to tell which original types were there.

Yeah, I left typedefs to make function decl look similar to the original.

Expand All Messages | Collapse All Messages