Issue 5689048: code review 5689048: net: make parseProcNetIGMP more robust

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5689048: code review 5689048: net: make parseProcNetIGMP more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by mikio

Modified:
13 years, 2 months ago

Reviewers:

CC:
rsc, borman, golang-dev

Visibility:
Public.

Description

net: make parseProcNetIGMP more robust Suggested by Paul Borman. Fixes issue 2826.

Patch Set 1 : diff -r f932feb2d870 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r be26a03f6be9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 92f426e8c1ff https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -17 lines)			Patch
M	src/pkg/net/interface_linux.go	View	3 chunks	+18 lines, -12 lines	0 comments	Download
A	src/pkg/net/interface_linux_test.go	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	src/pkg/net/interface_test.go	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/net/parse.go	View	1 chunk	+1 line, -1 line	0 comments	Download
A	src/pkg/net/testdata/igmp	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	src/pkg/net/testdata/igmp6	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello rsc@golang.org, borman@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2012-02-20 13:36:19 UTC) #1

mikio

Hello rsc@golang.org, borman@google.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 2 months ago (2012-02-21 12:41:19 UTC) #2

mikio

13 years, 2 months ago (2012-02-22 21:26:35 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b5a26af05931 ***

net: make parseProcNetIGMP more robust

Suggested by Paul Borman.

Fixes issue 2826.

R=rsc, borman
CC=golang-dev
http://codereview.appspot.com/5689048

Expand All Messages | Collapse All Messages