Don't strip the message anymore, it's breaking some dev use case

Don't strip the message anymore, it's breaking some dev use case

[gvrpython, 2012-02-20 03:46:42]

LG

Curious about the use case...

On Sun, Feb 19, 2012 at 6:10 PM,  <maruel@chromium.org> wrote:
> Reviewers: Andi Albrecht,
>
> Description:
> Don't strip the message anymore, it's breaking some dev use case
>
> Please review this at http://codereview.appspot.com/5689045/
>
> Affected files:
>  M upload.py
>
>
> Index: upload.py
> ===================================================================
> --- a/upload.py
> +++ b/upload.py
> @@ -2248,8 +2248,7 @@
>     prompt = "Title describing this patch set: "
>   else:
>     prompt = "New issue subject: "
> -  title = (
> -      title or message.split('\n', 1)[0].strip() or
> raw_input(prompt).strip())
> +  title = title or message.split('\n', 1)[0] or raw_input(prompt)
>   if not title and not options.issue:
>     ErrorExit("A non-empty title is required for a new issue")
>   # For existing issues, it's fine to give a patchset an empty name.
> Rietveld
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "codereview-discuss" group.
> To post to this group, send email to codereview-discuss@googlegroups.com.
> To unsubscribe from this group, send email to
> codereview-discuss+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/codereview-discuss?hl=en.
>



-- 
--Guido van Rossum (python.org/~guido)

[techtonik, 2012-02-20 07:01:35]

Me too, because we may strip it on server side.

[M-A, 2012-02-20 16:12:25]

They do -m" " to skip the prompt entirely.
Le 20 févr. 2012 02:01, <techtonik@gmail.com> a écrit :

> Me too, because we may strip it on server side.
>
>
http://codereview.appspot.com/**5689045/<http://codereview.appspot.com/5689045/>
>

[gvrpython, 2012-02-20 16:13:42]

LG. Ok.

On Mon, Feb 20, 2012 at 8:12 AM, Marc-Antoine Ruel <maruel@chromium.org> wrote:
> They do -m" " to skip the prompt entirely.
>
> Le 20 févr. 2012 02:01, <techtonik@gmail.com> a écrit :
>
>> Me too, because we may strip it on server side.
>>
>> http://codereview.appspot.com/5689045/



-- 
--Guido van Rossum (python.org/~guido)