code review 5688067: net/http: add overlooked 418 status code.

net/http: add overlooked 418 status code, per RFC 2324.

[dsymonds, 2012-02-22 08:37:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-22 09:10:47]

Lacks RFC reference.

Not sure how I like the look of the contractions.  Maybe StatusAmTeapot.

Blue.

On Wed, Feb 22, 2012 at 12:37 AM, <dsymonds@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/http: add overlooked 418 status code.
>
> Please review this at
http://codereview.appspot.com/**5688067/<http://codereview.appspot.com/5688067/>
>
> Affected files:
>  M src/pkg/net/http/status.go
>
>
> Index: src/pkg/net/http/status.go
> ==============================**==============================**=======
> --- a/src/pkg/net/http/status.go
> +++ b/src/pkg/net/http/status.go
> @@ -43,6 +43,7 @@
>        StatusUnsupportedMediaType         = 415
>        StatusRequestedRangeNotSatisfi**able = 416
>        StatusExpectationFailed            = 417
> +       StatusImATeapot                    = 418
>
>        StatusInternalServerError     = 500
>        StatusNotImplemented          = 501
> @@ -90,6 +91,7 @@
>        StatusUnsupportedMediaType:         "Unsupported Media Type",
>        StatusRequestedRangeNotSatisfi**able: "Requested Range Not
> Satisfiable",
>        StatusExpectationFailed:            "Expectation Failed",
> +       StatusImATeapot:                    "I'm a teapot",
>
>        StatusInternalServerError:     "Internal Server Error",
>        StatusNotImplemented:          "Not Implemented",
>
>
>

[dsymonds, 2012-02-22 09:50:24]

On Wed, Feb 22, 2012 at 8:10 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> Lacks RFC reference.

Fixed.

> Not sure how I like the look of the contractions.  Maybe StatusAmTeapot.

I think regularity wins here. It's a legacy.


Dave.

[bradfitz, 2012-02-22 09:54:43]

On Wed, Feb 22, 2012 at 1:50 AM, David Symonds <dsymonds@golang.org> wrote:

> On Wed, Feb 22, 2012 at 8:10 PM, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
>
> > Lacks RFC reference.
>

Fixed.
>

Oh, I meant in the CL description.  As a public comment I think it draws
too much attention to itself.

> Not sure how I like the look of the contractions.  Maybe StatusAmTeapot.
>
> I think regularity wins here. It's a legacy.
>

Fair enough.

Yellow.

[dsymonds, 2012-02-22 10:11:31]

On Wed, Feb 22, 2012 at 8:54 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> On Wed, Feb 22, 2012 at 1:50 AM, David Symonds <dsymonds@golang.org> wrote:
>>
>> On Wed, Feb 22, 2012 at 8:10 PM, Brad Fitzpatrick <bradfitz@golang.org>
>> wrote:
>>
>> > Lacks RFC reference.
>>
>>
>> Fixed.
>
>
> Oh, I meant in the CL description.  As a public comment I think it draws too
> much attention to itself.

Good point, fixed.

[bradfitz, 2012-02-22 10:15:00]

LGTM

On Wed, Feb 22, 2012 at 2:11 AM, David Symonds <dsymonds@golang.org> wrote:

> On Wed, Feb 22, 2012 at 8:54 PM, Brad Fitzpatrick <bradfitz@golang.org>
> wrote:
>
> > On Wed, Feb 22, 2012 at 1:50 AM, David Symonds <dsymonds@golang.org>
> wrote:
> >>
> >> On Wed, Feb 22, 2012 at 8:10 PM, Brad Fitzpatrick <bradfitz@golang.org>
> >> wrote:
> >>
> >> > Lacks RFC reference.
> >>
> >>
> >> Fixed.
> >
> >
> > Oh, I meant in the CL description.  As a public comment I think it draws
> too
> > much attention to itself.
>
> Good point, fixed.
>

[rsc, 2012-02-22 18:40:21]

http://codereview.appspot.com/5688067/diff/3005/src/pkg/net/http/status.go
File src/pkg/net/http/status.go (right):

http://codereview.appspot.com/5688067/diff/3005/src/pkg/net/http/status.go#ne...
src/pkg/net/http/status.go:46: StatusImATeapot                    = 418
The Im is really hard to read.  StatusTeapot, please.

[dsymonds, 2012-02-22 20:39:49]

http://codereview.appspot.com/5688067/diff/3005/src/pkg/net/http/status.go
File src/pkg/net/http/status.go (right):

http://codereview.appspot.com/5688067/diff/3005/src/pkg/net/http/status.go#ne...
src/pkg/net/http/status.go:46: StatusImATeapot                    = 418
On 2012/02/22 18:40:21, rsc wrote:
> The Im is really hard to read.  StatusTeapot, please.

That name makes it irregular with the other status names, which are all formal
contractions of their standard status text, but I defer to your superior teapot
nomenclature expertise. Done.

[rsc, 2012-02-22 20:41:45]

LGTM

It's okay that we're setting a new precedent:
this is a very unusual status message:
it has an apostrophe.

[dsymonds, 2012-02-22 20:51:55]

On Thu, Feb 23, 2012 at 7:41 AM, Russ Cox <rsc@golang.org> wrote:

> It's okay that we're setting a new precedent:
> this is a very unusual status message:
> it has an apostrophe.

Yeah, I agree. The new name is also appropriately short and stout.

[dsymonds, 2012-02-24 00:55:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=6b5680b2534c ***

net/http: add overlooked 418 status code, per RFC 2324.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5688067