Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(394)

Issue 5687046: code review 5687046: 5g, 6g, 8g: flush modified globals aggressively (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
CC:
ken2, golang-dev
Visibility:
Public.

Description

5g, 6g, 8g: flush modified globals aggressively The alternative is to record enough information that the trap handler know which registers contain cached globals and can flush the registers back to their original locations. That's significantly more work. This only affects globals that have been written to. Code that reads from a global should continue to registerize as well as before. Fixes issue 1304.

Patch Set 1 #

Patch Set 2 : diff -r 9af3fb3bc822 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e285ee3ad289 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/cmd/5g/reg.c View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/6g/reg.c View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/8g/reg.c View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2012-02-20 18:41:42 UTC) #1
rsc
13 years, 3 months ago (2012-02-20 18:41:48 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=8ee693ab43d1 ***

5g, 6g, 8g: flush modified globals aggressively

The alternative is to record enough information that the
trap handler know which registers contain cached globals
and can flush the registers back to their original locations.
That's significantly more work.

This only affects globals that have been written to.
Code that reads from a global should continue to registerize
as well as before.

Fixes issue 1304.

R=ken2
CC=golang-dev
http://codereview.appspot.com/5687046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b