Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1765)

Issue 5686067: code review 5686067: ssh: use *rsa.PublicKey or *dsa.PublicKey in interfaces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by agl1
Modified:
12 years, 2 months ago
Reviewers:
minux1
CC:
dave_cheney.net, r2, golang-dev
Visibility:
Public.

Description

ssh: use *rsa.PublicKey or *dsa.PublicKey in interfaces. Everywhere else in the code base, when we have an interface{} which is a stand in for a public key, we use *foo.PublicKey rather than foo.PublicKey. This change makes ssh reflect that.

Patch Set 1 #

Patch Set 2 : diff -r 080d73e214b6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 080d73e214b6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 080d73e214b6 https://agl%40golang.org@code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M ssh/client_auth.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M ssh/client_auth_test.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ssh/common.go View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6
agl1
Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://agl%40golang.org@code.google.com/p/go.crypto/
12 years, 2 months ago (2012-02-22 23:35:54 UTC) #1
r2
LGTM
12 years, 2 months ago (2012-02-23 01:11:28 UTC) #2
dave_cheney.net
LGTM. Thanks for cleaning this up.
12 years, 2 months ago (2012-02-23 09:41:07 UTC) #3
agl1
*** Submitted as 53e036e53a3c *** ssh: use *rsa.PublicKey or *dsa.PublicKey in interfaces. Everywhere else in ...
12 years, 2 months ago (2012-02-23 15:42:27 UTC) #4
minux1
Hi agl, Are you using latest codereview.py? On Thu, Feb 23, 2012 at 11:42 PM, ...
12 years, 2 months ago (2012-02-23 16:48:05 UTC) #5
agl1
12 years, 2 months ago (2012-02-24 18:30:14 UTC) #6
On Thu, Feb 23, 2012 at 11:47 AM, minux <minux.ma@gmail.com> wrote:
> Are you using latest codereview.py?

I appear to have a file that was updated yesterday.


Cheers

AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b