Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 5686058: code review 5686058: cmd/go: pass 2, remove reference to incomplete -file flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Mike.Rosset
Modified:
13 years, 3 months ago
Reviewers:
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

cmd/go: pass 2, remove reference to incomplete -file flag

Patch Set 1 #

Patch Set 2 : diff -r 19da4a6194b9 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 19da4a6194b9 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 19da4a6194b9 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 19da4a6194b9 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/go/test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
Mike.Rosset
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 3 months ago (2012-02-21 18:37:26 UTC) #1
minux1
http://codereview.appspot.com/5686058/diff/4001/src/cmd/go/test.go File src/cmd/go/test.go (right): http://codereview.appspot.com/5686058/diff/4001/src/cmd/go/test.go#newcode145 src/cmd/go/test.go:145: will compile the test binary which can be run ...
13 years, 3 months ago (2012-02-21 18:42:38 UTC) #2
Mike.Rosset
Hello golang-dev@googlegroups.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 3 months ago (2012-02-21 19:09:43 UTC) #3
Mike.Rosset
On 2012/02/21 18:42:38, minux wrote: > http://codereview.appspot.com/5686058/diff/4001/src/cmd/go/test.go > File src/cmd/go/test.go (right): > > http://codereview.appspot.com/5686058/diff/4001/src/cmd/go/test.go#newcode145 > ...
13 years, 3 months ago (2012-02-21 19:10:02 UTC) #4
rsc
s/runs/run/ as in "will compile and then (will) run"
13 years, 3 months ago (2012-02-21 19:40:06 UTC) #5
Mike.Rosset
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 3 months ago (2012-02-21 20:38:10 UTC) #6
Mike.Rosset
On 2012/02/21 19:40:06, rsc wrote: > s/runs/run/ > > as in "will compile and then ...
13 years, 3 months ago (2012-02-21 20:38:43 UTC) #7
rsc
LGTM. Thanks for keeping us honest.
13 years, 3 months ago (2012-02-21 20:41:58 UTC) #8
rsc
13 years, 3 months ago (2012-02-21 20:42:07 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=a194c22248eb ***

cmd/go: pass 2, remove reference to incomplete -file flag

R=golang-dev, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/5686058

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b