code review 5685070: godoc: fix playground url

godoc: fix playground url

[adg, 2012-02-21 22:57:20]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[gri, 2012-02-21 23:01:08]

I get a 404 for the /p link. But then I don't understand this code.
- gri

On Tue, Feb 21, 2012 at 2:57 PM,  <adg@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> godoc: fix playground url
>
> Please review this at http://codereview.appspot.com/5685070/
>
> Affected files:
>  M doc/root.html
>
>
> Index: doc/root.html
> ===================================================================
> --- a/doc/root.html
> +++ b/doc/root.html
> @@ -118,7 +118,7 @@
>                "outputEl":      "#output",
>                "runEl":         "#run",
>                "shareEl":       "#share",
> -               "shareRedirect": "http://play.golang.org/"
> +               "shareRedirect": "http://play.golang.org/p/"
>        });
>  }
>
>
>

[adg, 2012-02-21 23:06:06]

It's the base url to which we append a hash: http://play.golang.org/p/G5l93oM5ZW

On 22 February 2012 10:01, Robert Griesemer <gri@golang.org> wrote:
> I get a 404 for the /p link. But then I don't understand this code.
> - gri
>
> On Tue, Feb 21, 2012 at 2:57 PM,  <adg@golang.org> wrote:
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg
>>
>>
>> Description:
>> godoc: fix playground url
>>
>> Please review this at http://codereview.appspot.com/5685070/
>>
>> Affected files:
>>  M doc/root.html
>>
>>
>> Index: doc/root.html
>> ===================================================================
>> --- a/doc/root.html
>> +++ b/doc/root.html
>> @@ -118,7 +118,7 @@
>>                "outputEl":      "#output",
>>                "runEl":         "#run",
>>                "shareEl":       "#share",
>> -               "shareRedirect": "http://play.golang.org/"
>> +               "shareRedirect": "http://play.golang.org/p/"
>>        });
>>  }
>>
>>
>>

[gri, 2012-02-21 23:07:59]

LGTM

On Tue, Feb 21, 2012 at 2:57 PM,  <adg@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg
>
>
> Description:
> godoc: fix playground url
>
> Please review this at http://codereview.appspot.com/5685070/
>
> Affected files:
>  M doc/root.html
>
>
> Index: doc/root.html
> ===================================================================
> --- a/doc/root.html
> +++ b/doc/root.html
> @@ -118,7 +118,7 @@
>                "outputEl":      "#output",
>                "runEl":         "#run",
>                "shareEl":       "#share",
> -               "shareRedirect": "http://play.golang.org/"
> +               "shareRedirect": "http://play.golang.org/p/"
>        });
>  }
>
>
>

[adg, 2012-02-21 23:09:35]

*** Submitted as http://code.google.com/p/go/source/detail?r=459b632f17c9 ***

godoc: fix playground url

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5685070