code review 5685049: html/template: don't indirect past a Stringer

html/template: don't indirect past a Stringer

While we're here, get rid of the old names for the escaping functions.

Fixes issue 3073.

[r, 2012-02-20 03:00:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-02-20 03:04:30]

LGTM

what about in the other direction? e.g. passing a T that has String/Error method
on *T?

[rsc, 2012-02-20 03:17:26]

On Sun, Feb 19, 2012 at 22:04,  <dsymonds@golang.org> wrote:
> what about in the other direction? e.g. passing a T that has
> String/Error method on *T?

Since Stringify is being passed interface{} values,
it's too late: if the interface contains just a T, it
doesn't have a String method, because you can't
plausibly take the address of what amounts to a
temporary.

Most people who put a String method on a pointer
don't pass values around, though, so this is okay.

Russ

[r, 2012-02-20 03:23:50]

*** Submitted as c76997f376a5 ***

html/template: don't indirect past a Stringer

While we're here, get rid of the old names for the escaping functions.

Fixes issue 3073.

R=golang-dev, dsymonds, rsc
CC=golang-dev
http://codereview.appspot.com/5685049