code review 5683079: go cmd: print more than one error when running go test

go cmd: print more than one error when running go test

Fixes issue 3055.

[gri, 2012-02-22 23:39:29]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-02-23 01:10:29]

http://codereview.appspot.com/5683079/diff/4001/src/cmd/go/test.go
File src/cmd/go/test.go (right):

http://codereview.appspot.com/5683079/diff/4001/src/cmd/go/test.go#newcode304
src/cmd/go/test.go:304: n := 10 // only print the first n errors
more idiomatic would be const nErrors = 10
and then a regular for loop

[rsc, 2012-02-23 03:15:12]

LGTM

Thanks for fixing this

http://codereview.appspot.com/5683079/diff/4001/src/cmd/go/test.go
File src/cmd/go/test.go (right):

http://codereview.appspot.com/5683079/diff/4001/src/cmd/go/test.go#newcode304
src/cmd/go/test.go:304: n := 10 // only print the first n errors
if len(list) > 10 {
    list = list[:10]
}

should be fine

[gri, 2012-02-23 06:33:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=65578c6dc523 ***

go cmd: print more than one error when running go test

Fixes issue 3055.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5683079